broadway: Move from g_memdup() to g_memdup2()
authorEmmanuele Bassi <ebassi@gnome.org>
Thu, 4 Feb 2021 19:09:56 +0000 (19:09 +0000)
committerEmmanuele Bassi <ebassi@gnome.org>
Thu, 11 Feb 2021 14:22:22 +0000 (14:22 +0000)
The g_memdup() function is replaced by a safer version in newer versions
of GLib.

gdk/broadway/broadway-server.c
gdk/broadway/gdkbroadway-server.c
gdk/broadway/gdksurface-broadway.c

index a82b3e82df4115882dde241eba53ff85e60f9383..b54ae551494b09c20a93467b64df9b010b3dd2d5 100644 (file)
 #include <string.h>
 #endif
 
+#if !GLIB_CHECK_VERSION (2, 67, 3)
+# define g_memdup2(mem,size)    g_memdup((mem), (size))
+#endif
+
 typedef struct {
   int id;
   guint32 tag;
@@ -605,7 +609,7 @@ update_future_pointer_info (BroadwayServer *server, BroadwayInputPointerMsg *dat
 static void
 queue_input_message (BroadwayServer *server, BroadwayInputMsg *msg)
 {
-  server->input_messages = g_list_append (server->input_messages, g_memdup (msg, sizeof (BroadwayInputMsg)));
+  server->input_messages = g_list_append (server->input_messages, g_memdup2 (msg, sizeof (BroadwayInputMsg)));
 }
 
 static void
index 1aeb1649e9f21df73f88dc1ffc9f569d7f7b27e1..02b6f93183edfe7ced0e3b1b64fe0e691458d741 100644 (file)
@@ -13,6 +13,8 @@
 #include "gdkbroadway-server.h"
 
 #include "gdkprivate-broadway.h"
+#include "gdk-private.h"
+
 #include <gdk/gdktextureprivate.h>
 
 #include <glib.h>
@@ -233,7 +235,7 @@ static void
 parse_all_input (GdkBroadwayServer *server)
 {
   guint8 *p, *end;
-  guint32 size;
+  size_t size;
   BroadwayReply *reply;
 
   p = server->recv_buffer;
@@ -245,7 +247,7 @@ parse_all_input (GdkBroadwayServer *server)
       if (p + size > end)
         break;
 
-      reply = g_memdup (p, size);
+      reply = g_memdup2 (p, size);
       p += size;
 
       server->incoming = g_list_append (server->incoming, reply);
index 0d90e270a652fd0b249cbe3018bbb9e2dc8ea2fd..36930072c4959b941ea269aa2ca0fc8b67a152c0 100644 (file)
@@ -41,6 +41,7 @@
 #include "gdksurfaceprivate.h"
 #include "gdktextureprivate.h"
 #include "gdktoplevelprivate.h"
+#include "gdk-private.h"
 
 #include <graphene.h>
 #include <stdlib.h>
@@ -1025,7 +1026,7 @@ _gdk_broadway_moveresize_handle_event (GdkDisplay *display,
                 *mv_resize->moveresize_pending_event = *event;
               else
                 mv_resize->moveresize_pending_event =
-                  g_memdup (event, sizeof (BroadwayInputMsg));
+                  g_memdup2 (event, sizeof (BroadwayInputMsg));
 
               break;
             }
@@ -1043,7 +1044,7 @@ _gdk_broadway_moveresize_handle_event (GdkDisplay *display,
             *mv_resize->moveresize_pending_event = *event;
           else
             mv_resize->moveresize_pending_event =
-              g_memdup (event, sizeof (BroadwayInputMsg));
+              g_memdup2 (event, sizeof (BroadwayInputMsg));
 
           break;
         }